Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Exposure : range value setting limitation #8519

Merged
merged 12 commits into from Mar 25, 2021

Conversation

nohayassin
Copy link
Contributor

When setting Auto Exposure value outside the fixed limit, error will be printed to the log and AE value will remain as previous valid value.
Track on DSO-16596

src/ds5/ds5-options.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things that I marked is getting the range from the MANUAL_EXPOSURE value and doing the same fix for auto_gain_limit

src/ds5/ds5-options.cpp Outdated Show resolved Hide resolved
src/ds5/ds5-options.cpp Outdated Show resolved Hide resolved
src/ds5/ds5-options.h Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version looks good.
Note the conflict notification with the dev branch - needs to be resolved

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp ev-mp merged commit 0df661a into IntelRealSense:development Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants