Realsense2 warnings fixed #8821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Apr 19, 2021
common/utilities/time/work_week.cpp
Outdated
| @@ -39,8 +39,9 @@ namespace time { | |||
|
|
|||
| work_week::work_week( unsigned year, unsigned ww ) | |||
| { | |||
| if( ww == 0 || ww > work_weeks_between_years( year + 1, year ) ) | |||
| { | |||
| unsigned int yearww = unsigned(work_weeks_between_years(year + 1, year)); | |||
There was a problem hiding this comment.
Please put back into the next line
maloel
reviewed
Apr 19, 2021
src/usb/usb-request.h
Outdated
| @@ -22,7 +22,7 @@ namespace librealsense | |||
| { | |||
| public: | |||
| virtual rs_usb_endpoint get_endpoint() const = 0; | |||
| virtual int get_actual_length() const = 0; | |||
| virtual uint64_t get_actual_length() const = 0; | |||
There was a problem hiding this comment.
Dangerous -- and need to keep the type for "length" uniform -- so either int, size_t, or uint64_t
I prefer to keep int and not change interfaces for this. Please see if you can change the usages rather than the definition.
added 2 commits
April 19, 2021 13:49
maloel
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.