Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rs-convert - imu and pose support added for csv converter #8906

Merged
merged 6 commits into from May 5, 2021
Merged

rs-convert - imu and pose support added for csv converter #8906

merged 6 commits into from May 5, 2021

Conversation

remibettan
Copy link
Contributor

Tracked by: DSO-16987

ev-mp
ev-mp reviewed Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - please update the tool's documentation page and include the newly supported frame formats

tools/convert/converters/converter-csv.cpp Outdated Show resolved Hide resolved
tools/convert/converters/converter-csv.cpp Outdated Show resolved Hide resolved
@remibettan remibettan changed the title imu and pose support added rs-convert - imu and pose support added for csv converter Apr 28, 2021
ev-mp
ev-mp requested changes May 2, 2021
View reviewed changes
tools/convert/converters/converter-csv.cpp Outdated Show resolved Hide resolved
tools/convert/converters/converter-csv.cpp Show resolved Hide resolved
tools/convert/converters/converter-csv.cpp Outdated Show resolved Hide resolved
tools/convert/converters/converter-csv.cpp Outdated Show resolved Hide resolved
@ev-mp ev-mp merged commit aaebe18 into IntelRealSense:development May 5, 2021
maloel added a commit to maloel/librealsense that referenced this pull request May 6, 2021
@maloel
Revert "Merge pull request IntelRealSense#8906 from remibettan/rs-con…
6fcdca1 
…vert-support-imu-pose"

This reverts commit aaebe18, reversing
changes made to b505a6f.
maloel added a commit that referenced this pull request May 6, 2021
@maloel
Revert "Merge pull request #8906 from remibettan/rs-convert-support-i…
ad051d8 
…mu-pose"

This reverts commit aaebe18, reversing
changes made to b505a6f.
@maloel
Copy link
Collaborator

maloel commented May 6, 2021

This was found to increase warning count -- was reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-mp ev-mp ev-mp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@remibettan @maloel @ev-mp