Replace GVD queries with device update notification to verify device removal during DFU #8913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How come it's only one commit? Why don't I see a revert followed by your changes? |
maloel
reviewed
Apr 27, 2021
src/context.h
Outdated
| @@ -43,7 +43,7 @@ namespace librealsense | |||
| class device_info | |||
| { | |||
| public: | |||
| virtual std::shared_ptr<device_interface> create_device(bool register_device_notifications = false) const | |||
| virtual std::shared_ptr<device_interface> create_device(bool register_device_notifications = true) const | |||
There was a problem hiding this comment.
Have we checked that we always use the default arg?
There was a problem hiding this comment.
This parameter was removed, create device will always create it with a callback.
Verified playback work as expected.
There was a problem hiding this comment.
network device does not inherent device so it's good too.
maloel
reviewed
Apr 27, 2021
maloel
reviewed
Apr 27, 2021
maloel
reviewed
Apr 27, 2021
maloel
reviewed
Apr 27, 2021
maloel
reviewed
Apr 27, 2021
maloel
reviewed
Apr 27, 2021
maloel
reviewed
Apr 27, 2021
maloel
reviewed
Apr 27, 2021
maloel
reviewed
Apr 28, 2021
maloel
reviewed
Apr 29, 2021
maloel
reviewed
Apr 29, 2021
| @@ -256,7 +256,7 @@ namespace librealsense | |||
| } | |||
| } | |||
|
|
|||
| return ctx->add_device(file)->create_device(false); | |||
| return ctx->add_device(file)->create_device(); | |||
There was a problem hiding this comment.
So playback device will get notifications now? Can it even be "removed"?
There was a problem hiding this comment.
No, playback device override the create_device() function and is not calling the function we change it's defaults.
So it's OK, nothing changed there.
maloel
approved these changes
May 4, 2021
maloel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a ~6 seconds maximum loop to verify the device is disconnected after the DFU command (replacing HWM calls)
This partly reverts PR #8018 which caused freezes after DFUs.
Tracked on [RS5-11058]