Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playback deadlock on live tests (Git Actions CI fail) #9394

Merged
merged 1 commit into from Jul 15, 2021
Merged

Fix playback deadlock on live tests (Git Actions CI fail) #9394

merged 1 commit into from Jul 15, 2021

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Jul 14, 2021 •
edited by maloel

  • Bring back playback sensor flush on end-of-file or else last frames may get lost
  • Move sensor stop outside of mutex lock
  • Fix 2 unit-tests that did not stop & close the sensors

Tracked on [LRS-190]

@Nir-Az Nir-Az requested a review from maloel July 14, 2021 16:22
maloel
maloel approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about the testing before I merge...

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Jul 15, 2021

Let's talk about the testing before I merge...

Tests done:

  • libCI nightly x1 - pass
  • GH actions x5 - pass
  • Viewer free play on playback - pass

@maloel maloel merged commit 1b87d4b into IntelRealSense:development Jul 15, 2021
@maloel
Copy link
Collaborator

maloel commented Jul 15, 2021

LibCI:
http://rsjenkins.iil.intel.com:8080/job/LRS_libci_pipeline/1517/

@Nir-Az Nir-Az deleted the test_gh_actions_timeout branch July 27, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloel maloel maloel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nir-Az @maloel