Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add librealsense2 playback readme file #9412

Merged
merged 4 commits into from Jul 15, 2021
Merged

Add librealsense2 playback readme file #9412

merged 4 commits into from Jul 15, 2021

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Jul 15, 2021

No description provided.

@Nir-Az Nir-Az requested review from maloel and ev-mp July 15, 2021 06:09
ev-mp
ev-mp reviewed Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add the diagram sources (in text format) into the tool's resources folder to further tracking and modifications

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Jul 15, 2021 •
edited

Pls add the diagram sources (in text format) into the tool's resources folder to further tracking and modifications

Why under tools? it is not related to tools, it's related to documentation .
You think it's preferred to move it into another location?

ev-mp
ev-mp approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp ev-mp merged commit ecc3156 into IntelRealSense:development Jul 15, 2021
@Nir-Az Nir-Az deleted the playback_readme_file branch July 27, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-mp ev-mp ev-mp approved these changes

@maloel maloel maloel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nir-Az @ev-mp @maloel