Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .preset files for planned presets #9458

Merged
merged 3 commits into from Jul 22, 2021

Conversation

aangerma
Copy link
Contributor

Added json files:
Max Range With Binning.preset
Max Range.preset
Medium Range.preset
Min Range.preset

tracked on LRS-206

maloel
maloel previously approved these changes Jul 21, 2021
@maloel
Copy link
Collaborator

maloel commented Jul 21, 2021

What do you think, @aangerma : should the preset files have "L535" in their names, e.g. L535 Max range.preset?

@aangerma
Copy link
Contributor Author

What do you think, @aangerma : should the preset files have "L535" in their names, e.g. L535 Max range.preset?

I think its more clear

@ev-mp
Copy link
Collaborator

ev-mp commented Jul 21, 2021

In order for the files to be deployed with Debians they must listed in CMake targets.
I'm working on this in a parallel branch, but it should be in the form of
ev-mp@cf3abf4

@maloel maloel dismissed their stale review July 21, 2021 17:30

Waiting for new file names

@maloel maloel merged commit 33b13da into IntelRealSense:development Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants