Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix record and playback readme link #9547

Merged
merged 2 commits into from Aug 2, 2021
Merged

Fix record and playback readme link #9547

merged 2 commits into from Aug 2, 2021

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Aug 2, 2021

Tracked on [LRS-218]

@Nir-Az Nir-Az requested a review from maloel August 2, 2021 08:21
maloel
maloel reviewed Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nir-Az
Note that there are other references to media/readme in 3 more pages.

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Aug 2, 2021

@Nir-Az
Note that there are other references to media/readme in 3 more pages.

Weird, windows search didn't find them, nothing like the good old grep

Fixed

maloel
maloel reviewed Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about readme.md in the root of the tree?

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Aug 2, 2021

What about readme.md in the root of the tree?

Already fixed here:
https://github.com/IntelRealSense/librealsense/pull/9499/files#diff-5a831ea67cf5cf8703b0de46901ab25bd191f56b320053be9332d9a3b0d01d15R9

@maloel maloel merged commit 0c91e21 into IntelRealSense:development Aug 2, 2021
@Nir-Az Nir-Az deleted the fix_playback_readme_link branch May 3, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloel maloel maloel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nir-Az @maloel