Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rs-embed tool and update cameras 3d models #9764

Merged
merged 12 commits into from Sep 14, 2021
Merged

Add rs-embed tool and update cameras 3d models #9764

merged 12 commits into from Sep 14, 2021

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Sep 13, 2021

  • rs-embed added to the LRS tools
  • 3d model files has been updated to use LZ4 updated API

tracked on [LRS-290]

@Nir-Az Nir-Az mentioned this pull request Sep 13, 2021
Closed
@Nir-Az Nir-Az requested review from maloel and ev-mp September 13, 2021 13:27
maloel
maloel reviewed Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know I just realized that this way of doing things effectively declares all the binary data once per .cpp file that includes it ... but it looks like it's only included from one place for now, so...

maloel
maloel reviewed Sep 14, 2021
View reviewed changes
tools/embed/readme.md Outdated Show resolved Hide resolved
maloel
maloel reviewed Sep 14, 2021
View reviewed changes
tools/embed/rs-embed.cpp Outdated Show resolved Hide resolved
maloel
maloel reviewed Sep 14, 2021
View reviewed changes
tools/embed/rs-embed.cpp Outdated Show resolved Hide resolved
maloel
maloel approved these changes Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... I know it's not your code :)

@maloel maloel merged commit f0e9b2b into IntelRealSense:development Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloel maloel maloel approved these changes

@ev-mp ev-mp Awaiting requested review from ev-mp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nir-Az @maloel