Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractDelegateExtent requires FaweMaskManager to work #1330

Open
2 tasks done
Invvk opened this issue Sep 29, 2021 · 5 comments
Open
2 tasks done

AbstractDelegateExtent requires FaweMaskManager to work #1330

Invvk opened this issue Sep 29, 2021 · 5 comments
Labels
Approved Added if an issue has been approved by a maintainer Requires Testing This is a new issue which needs to be approved before labeled with "bug"

Comments

@Invvk
Copy link

Invvk commented Sep 29, 2021

Server Implementation

Paper

Server Version

1.17.1

Describe the bug

As the title says, this issue prevents use of custom extent if the plugin doesn't provide a custom FaweMaskManager. the issue is that Extent.setBlock will always return false and it won't send the changes, which makes almost all worldedit commands not working (//set,//replace... etc.. not sure if there are others).

so, it won't work if:

  • There is no FaweMaskManager provided by my plugin itself
  • if the provided FaweMaskManager.getMask(LocalPlayer, Location):
    • returns null
    • returns a dummy FaweMask with randomly selected points
    • if you are not inside the region that has been specified in the getMask(LocalPlayer, Location) (see below)

To understand this issue I will use this picture:

First case: no FaweMaskManager. it will break no matter what.

Second case: Using the custom AbstractDelegateExtent , a custom FaweMask with the minimum and the maximum point is selected randomly. if as an example if I use (//set,//replace etc...) commands and I want my custom AbstractDelegateExtent to set all blocks to sponge blocks regarding the user's input specifically in setBlock(BlockVector3, block) inside the redstone area it won't work. However if I change the minimum and maximum position pointing to the redstone area in the picture, it will work only inside the redstone area.

Third case: FaweMaskManager, with the getMask(LocalPlayer, Location) using the global region as minimum and maximum points. it will work everywhere and as expected.

To Reproduce

  1. Download This plugin.
  2. start the server.
  3. add this to your /plugins/WorldGuard/worlds/world/regions.yml.
  4. modify allowed-plugin like this inside /plugins/FastAsyncWorldEdit/config.yml.
  5. make sure you are not op and you have access to worldedit commands and don't forget to add permission fawe.fawe-bug-report & fawe.worldguard
  6. reload FAWE.
  7. try //set 1 inside the region I provided and it should ignore your input and set it to sponge block.
  8. now test it outside the region and it should not work at all, not even changing the blocks to stone.
  9. type /makeitglobal and restart the server. (This will set the minimum and maximum points using global region)
  10. now test it in and outside the region, it should ignore your input and set it to sponge blocks.
  11. type /breakitall and restart the server. (This will prevent the mask from being added)
  12. now test it in and outside the region, worldedit commands should stop working.
  13. to revert back to the original state type /makeitdefault

Expected behaviour

The expected behaviour is that AbstractDelegateExtent should work without relying on the fact that if the plugin provides a FaweMaskManager.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/15824e698b8f4d5a9071d36a7b7d12cc

Fawe Version

1.17-336;0ed9872

Checklist

Anything else?

This only applies to players who is not op but have the permission to use WorldEdit. But the question here is this how it is intended to work?

@Invvk Invvk added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Sep 29, 2021
@stale
Copy link

stale bot commented Nov 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If the issue is still present and can be reproduced, please let the team know. Thank you for your contributions.

@stale stale bot added the resolution: stale Old issues managed by stale bot label Nov 28, 2021
@dordsor21 dordsor21 added Approved Added if an issue has been approved by a maintainer resolution: stale Old issues managed by stale bot and removed resolution: stale Old issues managed by stale bot labels Nov 29, 2021
@stale stale bot removed the resolution: stale Old issues managed by stale bot label Nov 29, 2021
@Folas1337
Copy link

I'd like to express my interest in this issue and that I'd like to see it fixed as it would allow the worldedit flag of WorldGuardExtraFlags to work again.

@dordsor21
Copy link
Member

I believe I'd found the root cause of this some time ago, but have since forgotten and I cannot find it again :))

@OneLiteFeather
Copy link
Member

@dordsor21 what can we do for now?

@OneLiteFeather
Copy link
Member

I'd like to express my interest in this issue and that I'd like to see it fixed as it would allow the worldedit flag of WorldGuardExtraFlags to work again.

Does it work with newer versions again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Added if an issue has been approved by a maintainer Requires Testing This is a new issue which needs to be approved before labeled with "bug"
Projects
None yet
Development

No branches or pull requests

4 participants