Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed no-raw-text rule for typescript #220

Merged
merged 1 commit into from Apr 3, 2019
Merged

Fixed no-raw-text rule for typescript #220

merged 1 commit into from Apr 3, 2019

Conversation

AleksandrZhukov
Copy link
Contributor

@AleksandrZhukov AleksandrZhukov commented Mar 8, 2019 •
edited

  • fixed rule for @typescript-eslint/parser
  • added @typescript-eslint/parser as devDependency
  • added .DS_Store to .gitignore

@AleksandrZhukov
Copy link
Contributor Author

This PR fixes #208 and #210 issues

@AleksandrZhukov AleksandrZhukov mentioned this pull request Mar 8, 2019
Open
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 75.0% when pulling 6b5d67a on AleksandrZhukov:master into 89c3a11 on Intellicode:master.

@coveralls
Copy link

coveralls commented Mar 8, 2019 •
edited

Coverage Status

Coverage increased (+0.5%) to 75.577% when pulling b8a0636 on AleksandrZhukov:master into 89c3a11 on Intellicode:master.

@AleksandrZhukov
Fixed no-raw-text rule for typescript
b8a0636 
- fixed rule for @typescript-eslint/parser
- added @typescript-eslint/parser as devDependency
- added .DS_Store to .gitignore
@AleksandrZhukov AleksandrZhukov mentioned this pull request Mar 8, 2019
Closed
@donovanhiland
Copy link

🎉

@donovanhiland
Copy link

How long is typical for a review and merge of a PR like this?

@AleksandrZhukov
Copy link
Contributor Author

I don't know, seems need to ask @Intellicode 🙏

@Intellicode
Copy link
Owner

Thanks for your PR, I'm not very familiar with the use case of typescript and eslint, can you explain a little bit about the dev dependencies @AleksandrZhukov?

@AleksandrZhukov
Copy link
Contributor Author

@Intellicode I'm also not very familiar with typescript, but seems typescript-eslint/parser make little bit different AST from basic eslint parser. You can try to use another parser here https://astexplorer.net to check the difference. I've added typescript and typescript-eslint/parser dependencies to cover no-raw-text rule with tests.

@Intellicode
Copy link
Owner

@AleksandrZhukov alright, seems the other eslint react plugin has it as well, so lets go for it :)

@Intellicode Intellicode merged commit 0e1d377 into Intellicode:master Apr 3, 2019
@monotv monotv mentioned this pull request May 2, 2019
Closed
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request May 7, 2019
@monotv @facebook-github-bot
Update eslint-plugin-react-native dependency in eslint-config-react-n…
2becfab 
…ative-community package (#24686)

Summary:
I need this in my life because version 3.7.0 fixes [this](Intellicode/eslint-plugin-react-native#220) issue.

[General][fixed] - Fix an issue with `no-raw-text` rule for TypeScript by updating the eslint-plugin-react-native dependency to 3.7.0
Pull Request resolved: #24686

Differential Revision: D15237597

Pulled By: cpojer

fbshipit-source-id: 42ee13997d238025d0c50d154951549392d3abc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AleksandrZhukov @coveralls @donovanhiland @Intellicode