-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] Allow Inventory Manager to list, pull, and push to player Curios slots #480
base: release/1.18
Are you sure you want to change the base?
Conversation
One thing I noticed is, that you don't check if curios is loaded since it's a optional dependency So if curios is not loaded, the game would crash when someone runs these functions |
And ignore the failed github action, these currently do not work for pull requests |
I can suggest reusing peripheral plugin logic as environmental sensor do. |
Would implementing this as a plugin handle that? I'll give it a try |
Making sure I understand correctly: I should move the Curios calls to a new class in Edit: wait, BasePeripheral has |
Just encountered this: TheIllusiveC4/Curios#238 |
Oh indeed, that's a issue A workaround would be that we check the items before adding them |
Yeah, do it like edvin recommended it |
Any progress? I don't want to put you under pressure or give you time pressure |
I don't think I'll have it ready soon - academics kicked back up. I have an
idea on how to filter it, but making everything stable and all will take
time
…On Fri, Jul 7, 2023, 16:11 Srendi ***@***.***> wrote:
Any progress? I don't want to put you under pressure or give you time
pressure
I'm just asking because I'll release an update soon and want to know if
I'll include your changes or not
—
Reply to this email directly, view it on GitHub
<#480 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASLGEJ4JA3R7LLY5GNMMKLXPBUP7ANCNFSM6AAAAAAZ3TP4OU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Alright, no problem |
Greetings @Kurtoid |
Whoops, I took a break from minecraft and forgot about this. It looks like Curios now has the support needed to do this without workarounds (TheIllusiveC4/Curios#238 (comment)). I'm not sure if I can do it in a timely manner, though |
closes IntelligenceModding/Advanced-Peripherals-Features#8