Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tamed turtle #601

Merged
merged 34 commits into from
Jun 2, 2024
Merged

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Apr 27, 2024

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. This is not mandatory
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

    • Saddle turtle can capture player by invoking capture peripheral method, and release for dismount
    • It also can use getRider to get the information of the captured entity
    • When player is captured, press the inventory key (default E) can open the turtle's GUI
    • Updated all deprecated functions
  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)

  • Other information:

@zyxkad zyxkad marked this pull request as ready for review April 28, 2024 01:08
@zyxkad zyxkad requested a review from SirEndii April 28, 2024 02:30
@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 28, 2024

HUD stuff to show turtle fuel require Mixins and a read lot of minecraft asm, I don't think if I can done that recently.

If I got the HUD bar working, I'll make another PR

@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 28, 2024

As well as the saddle turtle's model need better saddle drawing, rather than just show the saddle on the side ...

@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 28, 2024

But anyways, forge already did that mixin for you, so the HUD is done 💦

@SirEndii SirEndii added this to the 0.8r milestone Apr 30, 2024
@SirEndii SirEndii added enhancement New feature or request 1.19x 1.20x labels Apr 30, 2024
@zyxkad
Copy link
Collaborator Author

zyxkad commented May 28, 2024

@SirEndii This is ready for review again

@SirEndii
Copy link
Member

gonna review that tomorrow
and I need to fix the actions stuff with prs

Copy link
Member

@SirEndii SirEndii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyxkad zyxkad merged commit 50062bd into IntelligenceModding:dev/0.8 Jun 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.19x 1.20x enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants