-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement game tests for more peripherals #612
Merged
SirEndii
merged 14 commits into
IntelligenceModding:feat/tests
from
dogboy21:peripheral-tests
May 21, 2024
Merged
Implement game tests for more peripherals #612
SirEndii
merged 14 commits into
IntelligenceModding:feat/tests
from
dogboy21:peripheral-tests
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyxkad
reviewed
May 13, 2024
src/testMod/resources/data/advancedperipheralstest/computer/tests/peripheraltest.geoscanner.lua
Outdated
Show resolved
Hide resolved
SirEndii
requested changes
May 21, 2024
...tMod/resources/data/advancedperipheralstest/computer/tests/modintegrtest.botaniamanapool.lua
Show resolved
Hide resolved
57c39ff
to
1954f8e
Compare
…od works correctly
SirEndii
approved these changes
May 21, 2024
Gonna revert this. I/we want to address some of the to-do's you mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Add game and junit tests to AP #562 is currently missing tests for many peripherals from AP
What is the new behavior (if this is a feature change)?
This PR implements game tests for the following peripherals:
ToDos:
getScanCooldown
method which currently does not exist in AP, so I cannot test it (the test currently uses the "internal"getOperationCooldown("scanBlocks")
method)isOnEnchantedSoil
function on Botania Mana Flowers always returns false, even when the flower is placed on enchanted soil. This seems to be the case because theovergrowth
variable on a Mana Flower is only set to true during the flower tick (see https://github.com/VazkiiMods/Botania/blob/1.20.x/Xplat/src/main/java/vazkii/botania/api/block_entity/SpecialFlowerBlockEntity.java#L100)isEmpty
method on Botania Mana Pools is currently missinggetBounding
method returning the coordinates of the block that the spreader is directed towards, shouldn't it be calledgetBinding
then?isEmpty
function on Botania Mana Spreaders does not return if the mana in the spreader is empty but if the item handler of the spreader is emptychangeNoteBy
is named somewhat weird. It sets the note value to the given parameter and does not change the note by x amount. Shouldn't it be calledsetNote
or something?