Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client test for the Chat Box peripheral #628

Merged
merged 5 commits into from
Jul 7, 2024

Conversation

dogboy21
Copy link
Member

@dogboy21 dogboy21 commented Jun 3, 2024

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

No tests for the Chat Box peripheral in #562

  • What is the new behavior (if this is a feature change)?

Added a test for the Chat Box with the new client test feature introduced in #622

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)

No


ToDo:

  • Implement tests for thechat event
  • Fix the runTestClient and runGameTestClient gradle tasks
    • The runTestClient task is used to build the test structures, so it needs to have the property advancedperipheralstest.tags set to common,client so that both server and client tests can be built and executed.
    • The runGameTestClient is used to automatically run client tests, so the property advancedperipheralstest.tags needs to set to client so we only run the client tests, not the server tests.
    • With the current implementation this does not work correcly and both server and client tests are run on the client

@SirEndii
Copy link
Member

I maybe can look into some of your to-dos when I find time

@dogboy21 dogboy21 marked this pull request as ready for review June 29, 2024 18:17
@SirEndii SirEndii self-requested a review June 30, 2024 01:05
@SirEndii SirEndii added the 1.19x label Jun 30, 2024
@SirEndii SirEndii added this to the 0.7.x milestone Jun 30, 2024
@SirEndii SirEndii merged commit 1acbce7 into IntelligenceModding:feat/tests Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants