Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Guides #25

Merged
merged 9 commits into from Sep 14, 2022
Merged

Chore: Guides #25

merged 9 commits into from Sep 14, 2022

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Sep 11, 2022 •
edited

Closes #22

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2022 •
edited

🦋 Changeset detected

Latest commit: c7284da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
d1-orm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Skye-31
Chore: start guides
d157dbf 
Content: to be made
@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 11, 2022 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c7284da
Status: ✅  Deploy successful!
Preview URL: https://b5824489.d1-orm.pages.dev
Branch Preview URL: https://chore-guides.d1-orm.pages.dev

View logs

@Skye-31 Skye-31 changed the title Chore: start guides Chore: Guides Sep 13, 2022
@Skye-31 Skye-31 marked this pull request as ready for review September 13, 2022 17:38
@Skye-31 Skye-31 added the documentation Improvements or additions to documentation label Sep 14, 2022
isaac-mcfadyen
isaac-mcfadyen reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@isaac-mcfadyen isaac-mcfadyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! A couple small comments, the biggest one I think is just around mentioning Wrangler.

guides/models.md Outdated Show resolved Hide resolved
guides/models.md Outdated Show resolved Hide resolved
guides/models.md Outdated Show resolved Hide resolved
guides/models.md Outdated Show resolved Hide resolved
Skye-31
Skye-31 commented Sep 14, 2022
View reviewed changes
Copy link
Contributor Author

@Skye-31 Skye-31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self reminder: make First() method add LIMIT 1

Skye-31 and others added 2 commits September 14, 2022 20:33
@Skye-31
Add LIMIT 1 to First()
91e3c3a
@Skye-31 @isaac-mcfadyen
Apply suggestions
c7284da 
Co-Authored-By: Isaac McFadyen <6243993+isaac-mcfadyen@users.noreply.github.com>
@Skye-31 Skye-31 merged commit 1750a55 into main Sep 14, 2022
@Skye-31 Skye-31 deleted the chore-guides branch September 14, 2022 20:02
@github-actions github-actions bot mentioned this pull request Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-mcfadyen isaac-mcfadyen isaac-mcfadyen left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Todo: Document QueryBuilder
2 participants
@Skye-31 @isaac-mcfadyen