Add the function of select columns #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 072b2c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Skye-31
requested changes
Jun 23, 2023
|
Understood, let me fix it. |
Skye-31
reviewed
Jun 25, 2023
Comment on lines
226
to
231
| public async First( | ||
| options: Pick<GenerateQueryOptions<InferFromColumns<T>>, "where"> | ||
| options: Pick< | ||
| GenerateQueryOptions<InferFromColumns<T>>, | ||
| "where" | "columns" | ||
| > | ||
| ): Promise<InferFromColumns<T> | null> { |
There was a problem hiding this comment.
One thing I've realised is that when the user is specifying columns, the return type of this method is going to be wrong - we'd only want to return the type for the columns which are being returned
There's not any particularly nice way to handle this though 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.