Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WITHOUT ROWID support #69

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Add WITHOUT ROWID support #69

merged 5 commits into from
Sep 11, 2023

Conversation

helloimalastair
Copy link
Contributor

@helloimalastair helloimalastair commented Sep 4, 2023

Add support for the WITHOUT ROWID clause.
Will error when conflicts are detected with AUTOINCREMENT.

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

🦋 Changeset detected

Latest commit: 0e80102

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
d1-orm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e80102
Status: ✅  Deploy successful!
Preview URL: https://44a81d70.d1-orm.pages.dev
Branch Preview URL: https://ali-without-rowid.d1-orm.pages.dev

View logs

@helloimalastair helloimalastair marked this pull request as ready for review September 5, 2023 08:35
@helloimalastair helloimalastair self-assigned this Sep 5, 2023
@helloimalastair helloimalastair added the enhancement New feature or request label Sep 5, 2023
Co-authored-by: Skye <46286597+Skye-31@users.noreply.github.com>
Copy link
Contributor

@Skye-31 Skye-31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helloimalastair
Copy link
Contributor Author

That confuzzled me, that there is both a TypeDoc and a seperate Doc...

@Skye-31
Copy link
Contributor

Skye-31 commented Sep 7, 2023

Typedoc is an API reference, actual docs explain it in a more textual way

@Skye-31 Skye-31 merged commit 2d5cbef into main Sep 11, 2023
4 checks passed
@Skye-31 Skye-31 deleted the ali/without-rowid branch September 11, 2023 16:21
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants