Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression by #2100 to building name allocation when same block used multiple times in same location #2237

Closed
Interkarma opened this issue Sep 3, 2021 · 0 comments
Assignees

Comments

@Interkarma
Copy link
Owner

First reported on forums. In Daggerfall/Oxville the block GEMRAM02.RMB is used twice in same location. From 0.11.4 with change #2100, buildings in these blocks no longer get assigned their unique names seeds from MAPS.BSA. More details in forum post below.

https://forums.dfworkshop.net/viewtopic.php?f=31&p=56792#p56792

@df-ferital I have a candidate fix for your review. I'll post this as a PR shortly.

@Interkarma Interkarma self-assigned this Sep 3, 2021
Interkarma added a commit that referenced this issue Sep 3, 2021
Potential fix for #2237.
This code was removed by #2100. However, it's necessary to edit then store a *copy* of block data for each block to have a unique name seed from MAPS.BSA, even when starting from same RMB data.
If data is modified in same instance of RMB data then second time block data is read it effectively overwrites first.
@df-ferital Please let me know if this causes any problems with your RMB caching. I'm not sure why this removed and I didn't catch this outcome in my review of your RMB caching PR. Thank you! :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant