factorize capacity computations #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factorize capacity computations (player carry capacity, wagon hold capacity, gold dropping into wagon), using floats to avoid rounding down bugs. Code that makes horse, wagon and arrows weightless was also factorized. Gold dropping message was left as-is to preserve Daggerfall classic behavior; However, when dropping gold into wagon, a post capacity check was added: if the wagon cannot accomodate the amount, only the gold that fits is dropped and a message is displayed. Bug report https://forums.dfworkshop.net/viewtopic.php?f=24&t=1587 I found another bug while factorizing: gold weight was counted twice in wagon, because it was handled with a special case when the common case was sufficient.
ajrb
reviewed
Dec 11, 2018
| DaggerfallMessageBox messageBox = new DaggerfallMessageBox(uiManager, this); | ||
| messageBox.SetText(String.Format(wagonFullGold, wagonCanHold)); | ||
| messageBox.ClickAnywhereToClose = true; | ||
| messageBox.Show(); |
There was a problem hiding this comment.
Maybe you could use this to shorten this boilerplate code for all the MsgBoxes you added:
DaggerfallUI.MessageBox(text);
|
Excellent work Pango, looks really good. |
|
Perfect, very happy how you sorted the gold weight out. |
|
Very clever! Thank you. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factorize capacity computations (player carry capacity, wagon hold
capacity, gold dropping into wagon), using floats to avoid rounding down
bugs.
Code that makes horse, wagon and arrows weightless was also factorized.
Gold dropping message was left as-is to preserve Daggerfall classic
behavior; However, when dropping gold into wagon, a post capacity check
was added: if the wagon cannot accomodate the amount, only the gold that
fits is dropped and a message is displayed.
Bug report https://forums.dfworkshop.net/viewtopic.php?f=24&t=1587
I found another bug while factorizing: gold weight was counted twice in
wagon, because it was handled with a special case when the common case
was sufficient.