Spell merchant improvements #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 30, 2019 19:28
I considered greying out spells from the merchant when the magicka cost is over your MaxMagicka; That is, you cannot casts them, even when fully rested. But greying out usually means stuff you cannot do, and you can still buy those spells, so I finally decided against it.
Interkarma
reviewed
Mar 31, 2019
| } | ||
| LoadSpellsForSale(); | ||
| // I'm not sure GameManager.Instance.PlayerEntity.MaxMagicka would be a good idea here | ||
| PopulateSpellsList(offeredSpells, null); |
There was a problem hiding this comment.
Agreed, I think you made the right choice here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort spells by alphabetic order, display spells magicka costs.
I considered greying out spells from the merchant when the magicka cost is over your MaxMagicka; That is, you cannot casts them, even when fully rested.
But greying out usually means stuff you cannot do, and you can still buy those spells, so I finally decided against it (the code is ready for such change though).
Forums: https://forums.dfworkshop.net/viewtopic.php?f=5&t=1916