Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix city gates regression #1273

Merged
merged 2 commits into from Apr 28, 2019
Merged

fix city gates regression #1273

merged 2 commits into from Apr 28, 2019

Conversation

petchema
Copy link
Collaborator

@Allofich
Copy link
Contributor

Allofich commented Apr 28, 2019 •
edited

Hm. Removing that comment causes

Assets/Scripts/Utility/RMBLayout.cs(817,36): warning CS0219: The variable `gate' is assigned but its value is never used

to appear in the Unity editor, but you're sure this fixes the issue? This warning is a false positive?

@Interkarma
Copy link
Owner

The component needs to be added, but it doesn't need to be stored as "gate". Can just remove that and leave the component intact for gate handling.

Thanks for looking into this Pango. :)

@Allofich
Copy link
Contributor

Ah, I see. Sorry for not being more careful when I originally commented it out.

@Interkarma
Copy link
Owner

Don't worry about it, I didn't catch it when I reviewed either. :)

@Interkarma Interkarma merged commit 4688ec1 into Interkarma:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petchema @Allofich @Interkarma