Improve KeyBind data handling #1322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, we can store unknown actions back, so newer builds won't lose the ability to use them. Change KeyBindData_v1 format to handle unknown actions better This modifies how the game loads in new keybindings and makes sure unknown actions get ignored.
|
I'm looking into adding a new binding UI a bit later in project, and may overhaul how bindings work to solve this same problem in a different manner. At this time though, I'm not wanting to change available keybinds or adjust how this is handled. I'm sorry for any inconvenience caused. |
|
Hi, no problem with that, I'm looking forward to the changes. |
This was referenced Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to tackle issues mentioned by #1320 (comment) by adding simple error resolution measurements to ensure backward and forward compatibility of the game.
Unknown actions will now be ignored by the
InputManager, but kept in memory, so we can store them back to the settings file once we rebuild it.