Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no fog on automap #1434

Merged
merged 3 commits into from Aug 21, 2019
Merged

no fog on automap #1434

merged 3 commits into from Aug 21, 2019

Conversation

petchema
Copy link
Collaborator

Make sure markers are not foggy when looking at the automap underwater

I added a script to the camera's gameObject to temporarily disable RenderSettings' fog, I don't know if that's the simplest way to fix that.

Forums:
https://forums.dfworkshop.net/viewtopic.php?f=4&t=163&p=29038#p29038

Pierre Etchemaite added 2 commits August 16, 2019 17:11
Make sure markers are not foggy when looking at the automap underwater

I added a script to the camera's gameObject to temporarily disable
RenderSettings' fog, I don't know if that's the simplest way to fix
that.

Forums:
https://forums.dfworkshop.net/viewtopic.php?f=4&t=163&p=29038#p29038
@petchema
Copy link
Collaborator Author

Some underwater save for testing:
SAVE42.zip

@Nystul-the-Magician
Copy link
Contributor

Nystul-the-Magician commented Aug 19, 2019

adding the script is ok I think, but it might be easier to just change RenderSettings' fog when automap is opened (function UpdateAutomapStateOnWindowPush) and backup old settings when it is closed (function UpdateAutomapStateOnWindowPop)
It is a matter of taste and design philosophy imo.
Personally, I would prefer if we add this to the automap code and don't add a script just for this one purpose tbh ;)
what do you guys suggest how to handle it?

@petchema
Copy link
Collaborator Author

The benefit of switching fog on the camera is that the water keeps being rendered correctly in the background:
automap-fog

@Nystul-the-Magician
Copy link
Contributor

Nystul-the-Magician commented Aug 19, 2019

that is a good point - from my side this justifies your approach as the superior one ;)

@Interkarma
Copy link
Owner

I'm sorry @petchema this one now has some conflicts in automap after merging Nystul's recent fixes. Might need to quickly rebase or add changes again. My apologies for the hassle.

@petchema
Copy link
Collaborator Author

Conflict was coming from change of line-return style, easy fix :)

@Interkarma Interkarma merged commit aef2dc6 into Interkarma:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants