Prevent game load from restoring players breath underwater #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from catching their breath when loading a game due to the fact they are temporarily at the entrance of the dungeon.
|
This is clean and works well. Thank you. :) |
Interkarma
added a commit
that referenced
this pull request
Oct 19, 2019
Was introduced by #1506 as short-circuit at front of PlayerEnterExit.Update() prevented some essential things updating during magic round catchup mechanic. One such item was determining if player was in darkness or not. As this check was skipped, player would acrrue several days of sun damage if they have their first vampire "death" after cautious fast travel and teleporting to crypt. Reworked slightly so that only swimming logic is being cut during PlayerEnterExit.Update() and other elements will catchup as before during artificial time increase.
Interkarma
added a commit
that referenced
this pull request
Oct 25, 2019
A change in #1506 prevented update running while player was resting. This broke a few things like random spawns during rest. Enemies would only spawn after rest ended. I'll take another look later at catching breath during load and find a different approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forum topic: https://forums.dfworkshop.net/viewtopic.php?f=24&t=2681
This is one approach to fixing the reported issue.
It seems to work fine on the saves I have, but this definitely needs thorough testing for side-effects.