Add water to dungeon automap #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petchema
commented
Jul 28, 2020
| @@ -2002,10 +2002,11 @@ private void CreateDungeonGeometryForAutomap() | |||
| { | |||
| if (elem.name.Contains("DaggerfallDungeon")) | |||
| { | |||
| DFLocation.DungeonBlock[] blocks = GameManager.Instance.PlayerEnterExit.Dungeon.Summary.LocationData.Dungeon.Blocks; | |||
There was a problem hiding this comment.
I had to base the automap on Summary.LocationData.Dungeon.Blocks instead of location.Dungeon.Blocks, because in the latter all block.WaterLevel are always 0.
Maybe I'm missing something.
There was a problem hiding this comment.
I think this is fine, even with SmallerDungeons enabled. The new dungeon layout is generated at a lower level and should be correct in this data at runtime.
|
Another screenshot of the MR in action... |
|
wow this looks amazing! great work! |
|
Glad you like it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks better than expected, given how simple is the shader modification.
The MR can be squashed, I attempted another approach first on this branch that doesn't need to stay around...