Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: DaggerfallStaticDoors.OnDrawGizmosSelected() to debug door trigger placements #2450

Conversation

andrew-raphael-lukasik
Copy link
Contributor

@andrew-raphael-lukasik andrew-raphael-lukasik commented Oct 19, 2022

What

This is small and unimportant PR. You can close it rn if you see it of no worth to the project.

Moves commented out "Debug trigger placement at start" code block from Start() and puts it into OnDrawGizmosSelected()

Why

I needed to see where the door triggers were... the code was ready written already, so.

Results

Door gizmos shows up when DaggerfallStaticDoors instance is selected only, so it wont pollute the screen nor slow down the editor everywhere. #if UNITY_EDITOR makes sure this won't ever end up in a build.

Screenshot 2022-10-18 232154

@Interkarma
Copy link
Owner

I think this is fine. I only used that block of code when developing door system and left it behind in case I needed it later, but I don't see any harm in showing these info as gizmos in editor.

@Interkarma Interkarma merged commit dbb1e65 into Interkarma:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants