Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust arrow position relative to camera rotation #2471

Merged
merged 1 commit into from Dec 16, 2022

Conversation

numidium
Copy link
Collaborator

@numidium numidium commented Dec 4, 2022

Prevents arrows spawning off-center from player perspective.

Problem:
When player aims the bow far enough up or down, arrows spawn noticeably off-center from the camera's perspective.

Solution:
Adjust the arrow origin "down" from the camera's perspective instead of moving it down the Y-axis.

Prevents arrows spawning off-center from player perspective.
@numidium numidium changed the title Adjust arrow Y relative to camera rotation Adjust arrow position relative to camera rotation Dec 4, 2022
@Interkarma
Copy link
Owner

Thank you, this looks better. It's a minor misalignment at very steep angles in any case, but this change shouldn't hurt anything.

I tested change as thoroughly as I could, and arrow still seem to go where the crosshair is aiming. That's good enough for me. :)

@Interkarma Interkarma merged commit 0f8dd23 into Interkarma:master Dec 16, 2022
@numidium numidium deleted the arrow-origin-fix branch December 16, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants