2430 fix %god macro for fighters guild #2478
Conversation
| case 0: return FactionFile.FactionIDs.Arkay; | ||
| case 1: return FactionFile.FactionIDs.Zen; | ||
| case 2: return FactionFile.FactionIDs.Mara; | ||
| case 3: return FactionFile.FactionIDs.Ebonarm; |
There was a problem hiding this comment.
Not sure about Ebonarm being in the random selection.
We could go full "Daggerfall urban legend" and make Ebonarm the "FG with Temple building type" deity, instead of a random selection. Having a random deity there might get them confused with religious knight orders
There was a problem hiding this comment.
I'm not familiar enough with the lore to be able to say which divines would be inappropriate to mention in a Fighters Guild hall.
I went with the original code comment "Better just to provide something than let let game loop crash".
|
Everything is a step up from just returning BLANK like classic. Not crashing is definitely an improvement over that. :) @KABoissonneault - I'm not much of a lore guy, but I see your point here. I'm happy to exclude Ebonarm after merge if you like? |
This is a fix for using a %god macro in a quest when inside a Fighters Guild hall in a region where this is considered a temple.
It will pick a random deity name, rather than crashing the quest.
I also fixed the existing random deity name selection, which could pick non-existing factionIds 23, 30, 31, 32 and 34.