Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flash_attn related operator dependency #214

Merged
merged 2 commits into from
May 17, 2024

Conversation

sallyjunjun
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

remove flash_attn related operator dependency.

Modification

remove fused_dense_lib

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@sallyjunjun sallyjunjun changed the title remove flash_attn related operator dependency [WIP]remove flash_attn related operator dependency Apr 28, 2024
@sallyjunjun sallyjunjun force-pushed the remove-flash-attn-dependency branch 2 times, most recently from b901c0b to 82ed77c Compare April 29, 2024 06:31
@sallyjunjun sallyjunjun changed the title [WIP]remove flash_attn related operator dependency remove flash_attn related operator dependency Apr 29, 2024
@sallyjunjun sallyjunjun force-pushed the remove-flash-attn-dependency branch 16 times, most recently from c80e028 to 691e7da Compare April 30, 2024 08:13
@sallyjunjun sallyjunjun force-pushed the remove-flash-attn-dependency branch 9 times, most recently from 5b8ff82 to 8d4ece0 Compare May 6, 2024 09:00
@sallyjunjun sallyjunjun force-pushed the remove-flash-attn-dependency branch 9 times, most recently from 1155cdc to f275e16 Compare May 7, 2024 03:42
@sunpengsdu sunpengsdu requested a review from li126com May 8, 2024 06:01
@@ -52,10 +52,8 @@ Install flash-attention (version v2.2.1):
cd ./third_party/flash-attention
python setup.py install
cd ./csrc
cd fused_dense_lib && pip install -v .
cd ../xentropy && pip install -v .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd xentropy && pip install -v .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sallyjunjun sallyjunjun force-pushed the remove-flash-attn-dependency branch 8 times, most recently from b32014a to 5a957fd Compare May 11, 2024 06:37
@sallyjunjun sallyjunjun force-pushed the remove-flash-attn-dependency branch 3 times, most recently from 7f93ced to fdf71fb Compare May 13, 2024 03:12
@sallyjunjun sallyjunjun force-pushed the remove-flash-attn-dependency branch from fdf71fb to e27caae Compare May 13, 2024 03:54
@sunpengsdu sunpengsdu merged commit cb9dd3c into develop May 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants