Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize sleep #1034

Merged
merged 1 commit into from
Jan 25, 2024
Merged

optimize sleep #1034

merged 1 commit into from
Jan 25, 2024

Conversation

grimoire
Copy link
Collaborator

@grimoire grimoire commented Jan 24, 2024 •
edited

  • Sleep would block coroutine
  • 10.6 req/s

AllentDan
AllentDan reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will block #974.

@grimoire
Copy link
Collaborator Author

@AllentDan https://docs.python.org/3/library/asyncio-task.html#running-in-threads can we turn the coroutine into thread?

@AllentDan
Copy link
Collaborator

@AllentDan https://docs.python.org/3/library/asyncio-task.html#running-in-threads can we turn the coroutine into thread?

It was resolved by changing the way to get items from a queue.

AllentDan
AllentDan approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit d5aa831 into InternLM:main Jan 25, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@AllentDan AllentDan AllentDan approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grimoire @AllentDan @lvhan028