Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pipeline guide and FAQ about OOM #1051

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

lvhan028
Copy link
Collaborator

Users complains about OOM a lot

@lvhan028 lvhan028 added the documentation Improvements or additions to documentation label Jan 26, 2024
@lvhan028 lvhan028 changed the title update guide and FAQ about OOM update pipeline guide and FAQ about OOM Jan 26, 2024
print(response)
```

A better approach would be to allocate space for the k/v cache from the free GPU memory proportionally. We will improve it in future versions for a better user experience.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been merged. So we may update this description. Thanks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Please review again

docs/en/faq.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 requested review from irexyc and removed request for zhyncs January 30, 2024 02:59
@lvhan028 lvhan028 merged commit a6ce188 into InternLM:main Jan 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants