Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix use engine_config.tp when tp is None #1057

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

zhyncs
Copy link
Contributor

@zhyncs zhyncs commented Jan 28, 2024

Motivation

fix memory equality check

Modification

use engine_config.tp when tp is None

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhyncs
Copy link
Contributor Author

zhyncs commented Jan 28, 2024

Hi @lvhan028 @AllentDan May you help review this pr? Thanks.

@lvhan028 lvhan028 merged commit 52419bd into InternLM:main Jan 29, 2024
4 checks passed
@zhyncs zhyncs deleted the patch-1 branch January 29, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants