-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix and change all logger using get_logger #1064
Conversation
fix change
搜了一下,还有一些文件用到了 |
@irexyc Sure, I will check that |
@irexyc Hi, I change the logging to get_logger in turbomind.py, and the reason some files require the use of import logging is because there is a need to set the level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Today, we are going to release v0.2.2. Let's put this PR to next version v0.2.3 |
@lvhan028 Sure |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
1.The get_logger function use mmengine get_logger, It will initialize CUDA, causing TurboMind to fail the second CUDA initialization.
2.Standardize the logger for all lmdeploy.
Modification
3.change get_logger implement
I add the log_formatter that it can easily change the format for the instance.
BC-breaking (Optional)
no
Use cases (Optional)
We can use the get_logger like
Checklist