Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mistral and sliding window attention #1075

Merged
merged 21 commits into from
Feb 23, 2024
Merged

Conversation

grimoire
Copy link
Collaborator

@grimoire grimoire commented Jan 31, 2024

  • Mistral 7b v0.1
  • sliding window attention kernel
  • window block manager
  • rename params

Important

This PR contains refactoring of the engine core mechanism.

@lvhan028 lvhan028 added the enhancement New feature or request label Jan 31, 2024
@zhyncs
Copy link
Contributor

zhyncs commented Feb 20, 2024

@grimoire is very productive, and the support for new models on the PyTorch engine is very timely. Currently, Mistral, Qwen 1.5, and DeepSeek MoE all rely on sliding window attention. @lvhan028 @RunningLeon Will we consider prioritizing this PR for review and merging it as soon as possible? Given that these are relatively large features, the community would likely appreciate being able to use them sooner rather than later.

@RunningLeon
Copy link
Collaborator

@grimoire is very productive, and the support for new models on the PyTorch engine is very timely. Currently, Mistral, Qwen 1.5, and DeepSeek MoE all rely on sliding window attention. @lvhan028 @RunningLeon Will we consider prioritizing this PR for review and merging it as soon as possible? Given that these are relatively large features, the community would likely appreciate being able to use them sooner rather than later.

@zhyncs Hi, feel free to review and test this PR. Any comment would be sincerely appreciated.

@lvhan028
Copy link
Collaborator

This PR makes a great change. QA needs more time to test it.
I am afraid it cannot catch the latest v0.2.4 version, which will be released this week.
We'll release it in v0.2.5 next week.

lmdeploy/model.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@lvhan028
Copy link
Collaborator

@RunningLeon Is there evaluation result of this PR?

@RunningLeon
Copy link
Collaborator

@RunningLeon Is there evaluation result of this PR?

here are the results. There might be something wrong.
13dde2c12e34d89a4b9aeeb7b25aec4

@lvhan028
Copy link
Collaborator

@zhulinJulia24 may perform regression test.

@RunningLeon
Copy link
Collaborator

@lvhan028 The perform test is OK as here
1708655711973

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 8d8f972 into InternLM:main Feb 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants