Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile order to launch the http service by docker run directly #1162

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Update Dockerfile order to launch the http service by docker run directly #1162

merged 2 commits into from
Feb 20, 2024

Conversation

AllentDan
Copy link
Collaborator

To test the PR. A new docker image should be built.

FROM openmmlab/lmdeploy:latest
ENTRYPOINT ["lmdeploy", "serve", "api_server"]

@AllentDan AllentDan linked an issue Feb 20, 2024 that may be closed by this pull request
openmmlab/lmdeploy镜像使用方法 #1154
Closed
@lvhan028 lvhan028 changed the title Update Dockerfile, user can launch the http service by docker run dir… Add entrypoint in Dockerfile in order to launch the http service by docker run directly Feb 20, 2024
lvhan028
lvhan028 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllentDan AllentDan changed the title Add entrypoint in Dockerfile in order to launch the http service by docker run directly Update documents in order to launch the http service by docker run directly Feb 20, 2024
@AllentDan AllentDan added the documentation Improvements or additions to documentation label Feb 20, 2024
RunningLeon
RunningLeon approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 changed the title Update documents in order to launch the http service by docker run directly Update Dockerfile order to launch the http service by docker run directly Feb 20, 2024
@lvhan028 lvhan028 removed the documentation Improvements or additions to documentation label Feb 20, 2024
@lvhan028 lvhan028 merged commit fef39a9 into InternLM:main Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@RunningLeon RunningLeon RunningLeon approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openmmlab/lmdeploy镜像使用方法
3 participants
@AllentDan @lvhan028 @RunningLeon