Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument error #1193

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix argument error #1193

merged 1 commit into from
Feb 26, 2024

Conversation

ispobock
Copy link
Contributor

Motivation

In #1189, the error message is confused due to the usage of ArgumentError is not correct.

Modification

Set the first parameter of ArgumentError as None to avoid this issue.

@ispobock
Copy link
Contributor Author

@lvhan028 @AllentDan Could you help review this PR?

@zhyncs
Copy link
Contributor

zhyncs commented Feb 26, 2024

LGTM

Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 3e1089c into InternLM:main Feb 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants