Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm unused var #1256

Merged
merged 1 commit into from
Mar 6, 2024
Merged

rm unused var #1256

merged 1 commit into from
Mar 6, 2024

Conversation

zhyncs
Copy link
Contributor

@zhyncs zhyncs commented Mar 6, 2024

Motivation

In turbomind 2.1, these variables are no longer used.

Modification

as titled

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhyncs
Copy link
Contributor Author

zhyncs commented Mar 6, 2024

Hi @lzhangzz @lvhan028 May you help review this pr? Thanks.

@lvhan028 lvhan028 requested a review from lzhangzz March 6, 2024 08:38
@zhyncs
Copy link
Contributor Author

zhyncs commented Mar 6, 2024

ping @lvhan028

@lvhan028 lvhan028 merged commit 50ca504 into InternLM:turbomind-2.1 Mar 6, 2024
9 checks passed
@zhyncs zhyncs deleted the patch-1 branch March 6, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@lzhangzz lzhangzz lzhangzz approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhyncs @lvhan028 @lzhangzz