Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more log info for api_server #1323

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Add more log info for api_server #1323

merged 2 commits into from
Mar 22, 2024

Conversation

AllentDan
Copy link
Collaborator

@@ -128,7 +128,7 @@ def get_logger(
formatter = ColorFormatter(log_formatter)
for handler in handlers:
handler.setFormatter(formatter)
handler.setLevel(log_level)
handler.setLevel(logging.DEBUG)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To enable --log-level DEBUG for the script. The current default log level is INFO, if a user wants to set DEBUG, he will get INFO level log only since DEBUG is lower than INFO. So we have to set the default level DEBUG for the handler to enable all the level choices.

@lvhan028 lvhan028 requested a review from grimoire March 21, 2024 12:51
@lvhan028 lvhan028 merged commit f43d099 into InternLM:main Mar 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants