-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support model_name customization for api_server #1403
Conversation
我感觉这个方案不太好,像 uuid 这种不能提供任何有用信息。 如果 vllm,fastchat等有类似的功能,我们可以参考。 可以有BC |
|
了解了。 |
model_name=args.model_name, | ||
meta_instruction=args.meta_instruction, | ||
capability=args.cap) | ||
chat_template_config = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta_instruction, capability 都没用了是么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
想把他们去掉,之前已经有 deprecate 一段时间了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去掉,我觉得也可以。merge下 latest main,看看 pr-test 的测试结果,可能有测试用例要改。
#1338