Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack cmakelist.txt in pr_test workflow #1405

Merged
merged 7 commits into from
Apr 8, 2024
Merged

hack cmakelist.txt in pr_test workflow #1405

merged 7 commits into from
Apr 8, 2024

Conversation

zhulinJulia24
Copy link
Collaborator

@zhulinJulia24 zhulinJulia24 commented Apr 7, 2024 •
edited

  1. [pr test] use cmake dependency other github repo
  2. [daily test] remove protobuf in workflow and make sure local testcase will be executed
  3. change kill into terminate because of pr handle SIGTERM #1389
  4. bugfix in vl pipeline testcase

@zhulinJulia24 zhulinJulia24 changed the title use locally pkgs in pr_test change cmake github repo in pr_test Apr 8, 2024
@zhulinJulia24
Copy link
Collaborator Author

I try to save _deps locally, it works manually test. But in workflow, it seems not stable because of CMake check error.

CMake Error: The current CMakeCache.txt directory /__w/lmdeploy/lmdeploy/build/_deps/repo-cutlass-subbuild/CMakeCache.txt is different than the directory /__w/lmdeploy/lmdeploy/lmdeploy/build/_deps/repo-cutlass-subbuild where CMakeCache.txt was created. This may result in binaries being created in the wrong place. If you are not sure, reedit the CMakeCache.txt

lvhan028
lvhan028 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RunningLeon
RunningLeon approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 changed the title change cmake github repo in pr_test hack cmakelist.txt in pr_test workflow Apr 8, 2024
@lvhan028 lvhan028 merged commit 60dc4fa into InternLM:main Apr 8, 2024
4 checks passed
@zhulinJulia24 zhulinJulia24 deleted the fix_torch_kill branch April 9, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@RunningLeon RunningLeon RunningLeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhulinJulia24 @lvhan028 @RunningLeon