add llava-v1.6-34b template #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
AllentDan
reviewed
Apr 8, 2024
|
|
||
| def __init__(self, | ||
| system='<|im_start|>system\n', | ||
| meta_instruction='Answer the questions.', |
There was a problem hiding this comment.
Did not find the instruction from https://huggingface.co/liuhaotian/llava-v1.6-34b/blob/main/tokenizer_config.json#L47
There was a problem hiding this comment.
lmdeploy/model.py
Outdated
| @@ -1031,6 +1031,43 @@ def match(cls, model_path: str) -> Optional[str]: | |||
| return 'dbrx' | |||
|
|
|||
|
|
|||
| @MODELS.register_module(name=['llava-v1_6-34b']) | |||
There was a problem hiding this comment.
Quite different from lmdeploy list. Seems models of llava use different chat templates?
lvhan028
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
llava-v1.6-34b use chatml format
https://github.com/haotian-liu/LLaVA/blob/main/llava/eval/run_llava.py#L76
Modification
Registry in mmengine treat
.as scope separator so I replace it with_