Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sampling kernel #1417

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

grimoire
Copy link
Collaborator

sampling kernel failed on triton>=2.2.0

@RunningLeon
Copy link
Collaborator

@zhulinJulia24 hi, pr test failed. Does it mean the pr has potential problem?

@zhulinJulia24
Copy link
Collaborator

@zhulinJulia24 hi, pr test failed. Does it mean the pr has potential problem?

Because of this issue. #1420
main is fixed. Should merge main first.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 911262f into InternLM:main Apr 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants