Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize slora #1447

Merged
merged 8 commits into from
May 8, 2024
Merged

Optimize slora #1447

merged 8 commits into from
May 8, 2024

Conversation

grimoire
Copy link
Collaborator

  • block size won't change after apply s-lora
  • remove slice op

@zhulinJulia24 zhulinJulia24 mentioned this pull request Apr 29, 2024
Merged
@lvhan028 lvhan028 requested a review from RunningLeon May 7, 2024 14:08
@lvhan028
Copy link
Collaborator

lvhan028 commented May 8, 2024

may resolve the conflicts

RunningLeon
RunningLeon approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 398c2aa into InternLM:main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@RunningLeon RunningLeon RunningLeon approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grimoire @lvhan028 @RunningLeon