Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: format internlm2 chat template #1456

Merged
merged 7 commits into from
Apr 22, 2024

Conversation

liujiangning30
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

lmdeploy/model.py Outdated Show resolved Hide resolved
@lvhan028 lvhan028 requested a review from AllentDan April 18, 2024 11:52
@lvhan028 lvhan028 changed the title Feat: format begin Feat: format internlm2 chat template Apr 18, 2024
@lvhan028
Copy link
Collaborator

pls fix linting error

@lvhan028
Copy link
Collaborator

UT about new added code snippet will be appreciated.

@lvhan028
Copy link
Collaborator

@Harold-lkk pls help review this PR

@AllentDan
Copy link
Collaborator

May provide an example or a unit test.

@lvhan028 lvhan028 merged commit fa4884a into InternLM:main Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants