Add input validation #1525
Merged
Add input validation #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhan028
reviewed
Apr 30, 2024
| @@ -101,6 +101,14 @@ def special_word_token_ids(words): | |||
| stop_words=special_word_token_ids(gen_config.stop_words), | |||
| bad_words=special_word_token_ids(gen_config.bad_words)) | |||
|
|
|||
| def __post_init__(self): | |||
There was a problem hiding this comment.
Let's make server return error message to users not crash
There was a problem hiding this comment.
This will not crash server
There was a problem hiding this comment.
This will not crash server
Hi @AllentDan Do we catch AssertionError and handle it when validation fails?
There was a problem hiding this comment.
Yes, we catch the error. Now, for the api_server, we check request before __post_init__
grimoire
reviewed
Apr 30, 2024
lmdeploy/serve/openai/api_server.py
Outdated
| return ret | ||
| if hasattr(request, 'model') and request.model not in get_model_list(): | ||
| return create_error_response( | ||
| HTTPStatus.NOT_FOUND, |
There was a problem hiding this comment.
The http status not found is designed to represent 404.
bad request should be ok here.
grimoire
approved these changes
Apr 30, 2024
irexyc
reviewed
Apr 30, 2024
lmdeploy/messages.py
Outdated
| assert type( | ||
| self.n) == int and self.n > 0, 'n is not a positive integer' | ||
| assert self.top_p > 0 and self.top_p <= 1 # (0, 1] | ||
| assert self.top_k >= 1, 'top_k must be a positive integer' |
There was a problem hiding this comment.
turbomind里面 top_k 可以是0，表示跳过top_k
|
ref #1324 |
zhyncs
approved these changes
May 6, 2024
zhyncs
reviewed
May 6, 2024
lmdeploy/serve/openai/api_server.py
Outdated
| if hasattr(request, 'top_k') and request.top_k < 0: | ||
| return create_error_response( | ||
| HTTPStatus.BAD_REQUEST, | ||
| f'The top_k `{request.top_p}` cannot be a negative integer.') |
There was a problem hiding this comment.
@AllentDan typo request.top_p -> request.top_k
lvhan028
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.