Fix transformers 4.41.0 prompt may differ after encode decode #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhan028
reviewed
May 20, 2024
| @@ -23,6 +23,7 @@ def test_tokenizer(model_path, input, interval, skip_special_tokens): | |||
| tokenizer = HuggingFaceTokenizer(model_path) | |||
| encoded = tokenizer.encode(input, False, add_special_tokens=False) | |||
| output = '' | |||
| input = tokenizer.decode(encoded, skip_special_tokens=skip_special_tokens) | |||
There was a problem hiding this comment.
这种追改兼容了各transformers的版本吗？
There was a problem hiding this comment.
只是改了 UT，增量解码我理解只要结果等于普通解码结果就OK。至于普通解码结果是不是一开始的 prompt，这可能是 transformers 关心的
There was a problem hiding this comment.
tokenizer.encode的部分需要把 add_special_token=False改成 add_special_token=add_special_token吗？
lvhan028
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following script failed with the latest transformers. The output differs from the input after encode and decode functions.