Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile #891

Merged
merged 7 commits into from
Dec 28, 2023
Merged

Update dockerfile #891

merged 7 commits into from
Dec 28, 2023

Conversation

RunningLeon
Copy link
Collaborator

Motivation

some problems while installing lmdeploy in the docker container

  • python3 -m pip install -e :
    • fails to install lmdeploy in editable mode as in issue 不能pip install -e #790
    • lmdeploy cli is unaccessible as lmdeploy package is not installed.
  • python3 -m pip install --user -e :
    • can successfully install lmdeploy in editable mode, but lmdeploy cli in not installed.

Modification

  • Use venv to fix installing lmdeploy in editable mode in docker containers
  • Upgrade torch to torch2.1.0+cu118 as pytorch-poc requires.
  • add __main__.py to enable using cli like python3 -m lmdeploy list.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@@ -17,10 +17,10 @@ on:
workflow_dispatch:
inputs:
repo_ref:
required: true
required: false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvhan028 lvhan028 merged commit 5c9b832 into InternLM:main Dec 28, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants