check-in ModelConfig #907
Merged
check-in ModelConfig #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhan028
reviewed
Jan 3, 2024
|
How |
from lmdeploy import pipeline, GenerationConfig, ModelConfig
from lmdeploy.turbomind import EngineConfig
model_config = ModelConfig(meta_instruction='[fake meta_instructin]')
pipe = lmdeploy.pipeline('internlm/internlm-chat-7b', backend_config=EngineConfig(), model_config = model_config)
gen_config = GenerationConfig(max_new_tokens=100, top_p=0.8, top_k=40, temperature=0.8)
response = pipe(prompts, gen_config, model_config) |
grimoire
reviewed
Jan 4, 2024
grimoire
reviewed
Jan 4, 2024
| capability: Optional[str] = None | ||
|
|
||
| @property | ||
| def model(self): |
There was a problem hiding this comment.
Setting builder method as property is a little bit strange.
There was a problem hiding this comment.
This is not supposed to be called frequently. And the build process is not computationally intensive.
|
May remove |
lvhan028
approved these changes
Jan 4, 2024
grimoire
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.