fix TorchEngine stuck when benchmarking with tp>1
#942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我这边会和之前一样卡住。@HIT-cwh 可以试下OK不？ |
|
May resolve conflicts. |
|
May fix the conflict |
lvhan028
reviewed
Jan 15, 2024
|
https://github.com/InternLM/lmdeploy/blob/main/lmdeploy/pytorch/config.py#L8C1-L16 这个地方应该有问题，torch_dtype 是GenerationConfig的属性，默认是None，所以default没什么用 |
lvhan028
approved these changes
Jan 22, 2024
lvhan028
changed the title
tp>1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pool is daemontic, create submodule in daemontic process is not allowed.